Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the TC responsibilities w.r.t. donations #594

Merged
merged 6 commits into from
Jan 12, 2021
Merged

Update the TC responsibilities w.r.t. donations #594

merged 6 commits into from
Jan 12, 2021

Conversation

bhs
Copy link
Contributor

@bhs bhs commented Jan 10, 2021

This change is as discussed at a GC meeting in December. Happy to take feedback and/or discuss the proposal if the TC is concerned about feasibility. cc @open-telemetry/technical-committee @open-telemetry/governance-committee

This change is as discussed at a GC meeting in December. Happy to take feedback and/or discuss the proposal if the TC is concerned about feasibility. cc @open-telemetry/technical-committee @open-telemetry/governance-committee
Copy link
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhs +1 to outlining how large donations are handled by OpenTelemetry.
It may also be useful to add some detail about

  • how to contact the TC when submitting a large code donation
  • outlining requirements such as an agreement to change of copyright to reflect the OpenTelemetry Authors and code license being compatible with Apache 2.0.
  • Code maintenance requirements

Also, move things around a bit to make them easier to find (hopefully).
@bhs
Copy link
Contributor Author

bhs commented Jan 11, 2021

@alolita great suggestions. I updated this PR to include more guidance (per your comment) and moved some of that guidance into CONTRIBUTING.md where I'd look for it if I were an outside donator.

@bhs
Copy link
Contributor Author

bhs commented Jan 12, 2021

I can theoretically merge this given the approvals, but I changed the PR in meaningful ways since those approvals came through. Would love an explicit 👍 from an approver before this gets merged.

CONTRIBUTING.md Outdated
guidance at the TC's earliest convenience.

All donated code requires a license compatible with the Apache Software License
2.0 (ASL 2), and donated code will require a change of copyright to reflect the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I have never seen abbreviation "ASL 2" before. Not sure what the purpose of using it here is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting – I have seen it, but I am also glad to remove it :) Will do.

@bhs bhs merged commit 1d75235 into master Jan 12, 2021
@bhs bhs deleted the bhs-patch-1 branch January 12, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants